Vulkan and Opengl swapable rendering backend
I'm working on a multi render library. The point of it is to have a swapable backend at runtime to render the same item.
The renderer is given to the window (which is a wrapper over SDL2). Then the window is in charge of drawing a IDrawable, which is a virtual class implemented in a namespace for each backend. The implementation of IDrawable in each namespace got the same tag as the backend, for preventing rendering a drawable with the wrong backend.
Here's the code. I would appreciate some reviews on the architecture; what's good and what's wrong.
Создан 03 июл. 17 2017-07-03 17:33:48 Bl4ckb0ne
First of all: OpenGL and Vulkan work very differently in some parts. In the following i assume you are already familiar with vulkan.
There would probably some problems arise with the current design. You cannot just render something like that in vulkan, a vulkan drawable cannot implement the draw() function without that you maintain any global state (which you hopefully don't want, one of the strengths of vulkan is that you don't need that anymore and therefore gain things like threadsafety and a more reliable api performance). You would at least need a command buffer to record into, but this would change the meaning of the draw interface on different backends (immediate rendering on opengl vs recording on vulkan), which is bad. Additionally, in this case every drawable would change the bound pipeline (another thing that can be optimized using vulkan). In the end it would maybe make sense to handle drawing entirely in the renderer and maybe only expose things like material and vertices from the drawable. Every drawable could e.g. own a Buffer object which is an interface that might be a vulkan or an opengl buffer and managed by the renderer (those are the parts where one could really nicely abstract opengl and vulkan). In the end this also drives away the need for this rather smelly tag-based polymorphism pattern, and allows to model things in a easier, more natural way (which is usually a good sign). When you render using e.g. vulkan there should not be any opengl drawables around (should there? not a sign if there could be. ) so there is no need to use this tag checking.
I am not sure your use of templates is optimal. In this case (although you just write the type Window in both cases) the both Windows are actually totally different types and therefore could not be changed at runtime. This means if you want to change the renderer you have to change the code somewhere which is probably not what you want (The same for the Renderer class). It would make more sense to have something like virtual (or even abstract) Renderer and Window interfaces that are then implemented by
You use C++17 features (and compile using this flag) so i assume you want to write modern C++. If so use the (great) features modern C++ gives you:
- Use enum class Tag instead of enum Tag for type safety and less name pollution
- Use the override keyword for functions that implement virtual ones
- Use references where a nullptr is not a val >draw method makes much sense in a Renderer but not so much in a Window (although there are many Window abstractions like this, this will lead to design issues later).
Also: No matter in which stage code is, don't name your >D . And IMO Vulkan isn't a really good name either, choose something like VulkanBackend instead (same of OpenGL).
Those were just some first things that came to my mind (there are of course also things done right in your code i did not mention), there is probably more to say about it. An abstraction like this is really hard to build and (as a small - maybe opinionated - side note) it probably makes more sense to focus on one of the both api's if you do not absolutely need both since they are really different (at least in some, critical places like the rendering - plan global calls vs command buffer recording).
Создан 06 июл. 17 2017-07-06 17:56:23 nyorain
Thanks for your review. I'm not familiar with vulkan at all, so that's why I wanted to start this project. As I said, this is a premininary architecture, nothing is written yet (that explains the really bad naming). I'll start to work on a standalone project with vulkan this week end to have a taste of the beast and come up with a better design. – Bl4ckb0ne 06 июл. 17 2017-07-06 19:28:31